Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index 

On 04/27/2012 02:54 PM, Jan Holesovsky wrote:

Jesús Corrius píše v Čt 26. 04. 2012 v 15:52 +0200:

I have added a comment so it doesn't happen again:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=34fe1bed19e4cf66500d7e7817eb251c42f8f439


#ifdef WNT / #endif would be better
Would it really be better? With our huge configuration matrix, I guess there will always be functions left unused for some specific configurations. #ifdef'ing up the code to avoid that in general would IMO not make the code better, but worse (by cluttering it with #ifdefs).
If a class has some generally-useful--looking member functions that happen to only be used with certain configurations, I see nothing bad with leaving them in unconditionally. (Note, I have no idea whether the given FontSelectPattern ctor qualifies.) 

Stephan

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.