Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi Caolan,

On Tue, Apr 24, 2012 at 3:22 PM, Caolán McNamara <caolanm@redhat.com> wrote:
On Tue, 2012-04-24 at 19:03 +0100, José Santiago Jiménez Sarmiento

What bothers me about the unused GetNextVisPortion in editeng is that
GetPrevVisPortion is not unused, and in
EditView::SetSelection I wonder if the *second* GetPrevVisPortion should
have been GetNextVisPortion all along.

caolanm->kohei, I suppose you haven't picked up any insights during your
editeng refactor ?

I haven't picked up on edit engine well enough to answer that question
comfortably.  Having said that, the second call indeed would make more
sense if it were GetNextVisPortion() just by the look of it.  Again,
I'm not an expert on this code yet so take my comment for what it's
worth....

FWIW it was already like that in 3.5.

Kohei

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.