Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

Lubos Lunak píše v Po 23. 04. 2012 v 13:37 +0200:
> On Monday 23 of April 2012, Petr Mladek wrote:
> > Hmm, we might want to keep the strip stuff and the -dontstrip options in
> > the in the perl installer. It is handy when you have debug build and you
> > need to send someone the small stripped build. It is a big difference in
> > the size. I am not sure if "make install" should strip by default or
> > not. Bjoern, Lubos, what do you think?
>
>  It should not, it should do what the name says. If the functionality is 
> deemed useful, it can be an extra target like other build systems have (e.g. 
> automake has install-strip).

Hmm, it is a bit more complicated. The installation sets, for the
upstream release, are generated during normal build. "make install" is
called only by developers or Linux distro packagers.

I am not sure but I think that strip reduces size of binaries even when
you build without -g. It just removes something less important. I am not
sure what is the win but we might want to always strip binaries for the
official installation sets to optimize download size for normal users. 

David, could you please do some investigation here? I wonder what is the
difference when you build without debugging symbols and when you strip
or non-strip the final binaries in the installation set.

If you do tests on linux. You might want to use --enable-epm
--with-package-format="rpm deb" and compare the generated tar.gz in
instsetoo_native/unxlng?6.pro/LibreOffice/*/install/*_download

Make sure that you do not strip in solver:
        + remove strip in deliver.pl
        + remove strip in the gbuild makefiles

Also you need to be capable to strip in the perl installer
        + use or not use -dontstrip when calling make_installer.pl in
          instsetoo_native/util/makefile.mk


Best Regards,
Petr

PS: Your original patch actually forgot to update
instsetoo_native/util/makefile.mk :-)