On Sat, 2012-04-14 at 15:30 +0200, Arnaud Versini wrote:
Hi
This patch replace SV_DECL_PTRARR_DEL by a simple ptr_vector in
WW8ListManager.
Looks good, pushed now, sorry for the delay
I'm not sure about this comment in the destructor, the object is
always destroyed, I think we should use a ptr_vector too, or don't
destroy unconditionally (*aIter).
The comment is correct, best read split like...
"named lists remain in doc!!!
unnamed lists are deleted when unused"
which refers to the conditional use of DelNumRule to remove unused
automatic numbering rules from the final imported document, while
"pLFOInfos are in any case destructed" refers to the deletion of the
contents of pLFOInfos (etc). Committed a change to the comment now.
Yup, you could use a ptr_vector there if you wanted.
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.