Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi

This patch replace SV_DECL_PTRARR_DEL by a simple ptr_vector in
WW8ListManager.

I'm not sure about this comment in the destructor, the object is always
destroyed, I think we should use a ptr_vector too, or don't destroy
unconditionally (*aIter).

/*
    named lists remain in doc!!!
    unnamed lists are deleted when unused
    pLFOInfos are in any case destructed
    */
    for(std::vector<WW8LSTInfo *>::iterator aIter = maLSTInfos.begin();
        aIter != maLSTInfos.end(); ++aIter)
    {
        if ((*aIter)->pNumRule && !(*aIter)->bUsedInDoc &&
            (*aIter)->pNumRule->IsAutoRule())
        {
            rDoc.DelNumRule((*aIter)->pNumRule->GetName());
        }
        delete *aIter;
    }

Thanks in advance for reviewing

Best regards

-- 
Arnaud Versini

Attachment: 0001-Use-boost::ptr_vector-in-WW8ListManager-instead-of-SV_DECL_PTRARR_DEL.patch
Description: Binary data


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.