Re: [PATCH] Removed duplicate set/get methods for initial tab count (fails while linking vbaobj.uno.so)

Hello Albert,

2012/4/17 Albert Thuswaldner <albert.thuswaldner@gmail.com>:
> Hi,
> This patch removes the duplicate Get/Set methods in appoptio.hxx which
> the vba api uses. There was a long discussion back in the day about
> this:
>
> http://lists.freedesktop.org/archives/libreoffice/2011-June/013114.html
>
> I CC:ing Noel Power if he as some opinion regarding this.
>
> Now to the problem with this patch:
>
> This patch makes the build fail in when linking vbaobj.uno.so:
>
> /home/thuswa/work/libo2/workdir/unxlngi6.pro/CxxObject/sc/source/ui/vba/vbaapplication.o:
> In function `ScVbaApplication::getSheetsInNewWorkbook()':
> /home/thuswa/work/libo2/sc/source/ui/vba/vbaapplication.cxx:942:
> undefined reference to `ScModule::GetDefaultsOptions()'
> /home/thuswa/work/libo2/workdir/unxlngi6.pro/CxxObject/sc/source/ui/vba/vbaapplication.o:
> In function `ScVbaApplication::setSheetsInNewWorkbook(long)':
> /home/thuswa/work/libo2/sc/source/ui/vba/vbaapplication.cxx:955:
> undefined reference to `ScModule::GetDefaultsOptions()'
> collect2: ld returned 1 exit status
> make[1]: *** [/home/thuswa/work/libo2/workdir/unxlngi6.pro/LinkTarget/Library/vbaobj.uno.so]
> Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [sc] Error 2
>
> I cant find a logical reason why this fails. The "scmod.hxx" which
> defines the symbol is included as before, also considering the minimal
> changes that I have made to the file:

You need to export GetDefaultsOptions with SC_DLLPUBLIC in scmod.hxx.

Regards,
Markus