Re: [PATCH] Bug 48140 - [EasyHack] remove uno calls from xlsx import

Hi Daniel,

On Tue, 2012-04-17 at 08:45 -0400, Kohei Yoshida wrote:
> I'll look through your changes to see what change might have caused
> the shared formula import issue. 

This change

-    Reference< XNamedRange > xNamedRange = createNamedRangeObject( aName, rTokens, 0 );
-    OSL_ENSURE( xNamedRange.is(), "SheetDataBuffer::createSharedFormula - cannot create shared 
formula" );
-    PropertySet aNameProps( xNamedRange );
-    aNameProps.setProperty( PROP_IsSharedFormula, true );
+    ScRangeData* pScRangeData = createNamedRangeObject( aName, rTokens, 0 );

in SheetDataBuffer::createSharedFormula() may be the culprit.  I haven't
verified it with 100% certainty, but this change certainly smells.

Refer to

http://opengrok.libreoffice.org/xref/core/sc/source/ui/unoobj/nameuno.cxx#392

for what actually takes place when setting a boolean "IsSharedFormula"
property to the named range UNO object.

HTH,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc