On Thursday 12 of April 2012, Rafael Dominguez wrote:
This are the hardest ones to port, since the rExchangeList parameter uses
the last position from InsertBookmarkAsPage in InsertBookmarkAsObject, so
the best idea i came up with to avoid doing nasty stuffs was erase procesed
objects in InsertBookmarkAsPage and add an extra parameter to
InsertBookmarkAsObject that recalculates object count when rExchangeList
has items but its manipulated by InsertBookmarkAsPage first like it occurs
in function SdDrawDocument::InsertBookmark.
Seems reasonable, to keep the behaviour of the old version. But the comment
you added to the code next to the erasing probably doesn't explain much other
than that the code is there for some reason, this comment above explains it
better, so I've added it to the commit log message. Otherwise the patches
looked good.
--
Lubos Lunak
l.lunak@suse.cz
Context
Re: [PATCH] 2/2 List cleanup in SD · Lubos Lunak
Re: [PUSHED][PATCH] 2/2 List cleanup in SD · Caolán McNamara
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.