Re: [PATCH] 2/2 List cleanup in SD

On Thursday 12 of April 2012, Rafael Dominguez wrote:
> More cleanup of related functions.
> I changed IterateBookmarkPages method to be a local function since its used
> only in drawdoc3.cxx
> 0010-Remove-unused-InsertBookmarkAsPage_AddBookmarkedPage.patch
>
> 0011-Refactor-SdDrawDocument-IterateBookmarkPages.patch

[ build CXX ] sd/source/core/drawdoc3.cxx
/home/llunak/build/src/l2/sd/source/core/drawdoc3.cxx:80:7: 
warning: 'InsertBookmarkAsPage_FindDuplicateLayouts' has virtual functions 
but non-virtual destructor [-Wnon-virtual-dtor]
class InsertBookmarkAsPage_FindDuplicateLayouts
      ^
/home/llunak/build/src/l2/sd/source/core/drawdoc3.cxx:84:11: error: 
initializer 'mpLayoutsToTransfer' does not name a non-static data member or 
base class; did you mean the member 'mrLayoutsToTransfer'?
        : mpLayoutsToTransfer(rLayoutsToTransfer) {}
          ^~~~~~~~~~~~~~~~~~~
          mrLayoutsToTransfer
/home/llunak/build/src/l2/sd/source/core/drawdoc3.cxx:87:33: 
note: 'mrLayoutsToTransfer' declared here
    std::vector<rtl::OUString> &mrLayoutsToTransfer;
                                ^
1 warning and 1 error generated.

 I've removed the unnecessary virtual on the operator() and fixed the error 
before pushing.

-- 
 Lubos Lunak
 l.lunak@suse.cz