check : build dependency (was: Re: what exactly needs localedata_en library ?)

On 12 April 2012 16:14, Eike Rathke <erack@redhat.com> wrote:
> On Thursday, 2012-04-12 13:33:38 +0200, Lubos Lunak wrote:
>
> >  As far as I can see, it is the i18npool library that dlopens localedata_en
> > (i18npool/source/localedata/localedata.cxx), so I think the best way to
> > express this dependency is to make i18npool depend on localedata_en (and
> > localedata_es, localedata_euro and localedata_others).
>
> Might be an approach. While at it, dependencies on the various libdict_*
> and lib*_data* that are dlopen'ed by i18npool could be added as well.

Hmm, for now I created:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5dce272584cc79da727bdd4887d60cec04cbce11
I did not put there libdict_* and lib*_data*

Maybe it is better to just let check target depend on build target ?
In general.
It could prevent more missing dependencies in future.

In tail_build, all tests would run in the end, so no chance to stop
the build process if there is something wrong
and _maybe_ it would take more time because of less effective ordering.
But there is no guarantee for ordering anyway and I can't see any
problem with this.

Does it make sense to add:
check : build dependency ?

Or do people use make check with demand to build only what is
necessary for tests and nothing more ?

--
Matus