On Thu, Apr 12, 2012 at 10:06 AM, Caolán McNamara <caolanm@redhat.com> wrote:
On Thu, 2012-04-12 at 09:46 -0400, Kohei Yoshida wrote:
Crap. Maybe a unit test in editeng wasn't such a good idea after all.
I disabled it and backed out a few bit for the moment. I have a fairly
good idea what the various problems are so I might have a go at fixing
it up again in a bit.
*mumable* unotest::testDown has its "dispose" commented out ages ago,
putting that back in shows some other problems with various mixes of
global singletons that exist for the duration of a test-suite and the
per-test globals which get setup and reset for each test.
Yes. Some of my changes were an attempt to address that. But
apparently my skill is not up for it.
I give up now. You did the right thing by backing out my changes.
Kohei
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.