Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On 04/11/2012 05:17 PM, Matúš Kukan wrote:
I was investigating which dependency is missing for sometimes failing
i18npool_test_breakiterator and it is localedata_en.

The dependency was often explicitly written in sc's makefiles (but
i18npool is not yet in tail_build, so not needed) and I think:
gb_CppunitTest_use_ure,foo =>  foo requires localedata_en
is true, so I created attached patch where the dependency is moved to
gb_CppunitTest_use_ure definition.
But I don't know if also the other implication is true:
gb_CppunitTest_use_ure,foo<= foo requires localedata_en

I did not push yet but if no one is against I will do so soon because
it is safe and maybe also the right thing to do ?

Safe: at least as long as people do not want to use the other features of gb_CppunitTest_use_ure (like specifying UNO_TYPES and UNO_SERVICES) in a test that should be runnable before i18npool is built.

The right thing: probably not. Rather, a consequence of too fat (unit) test dependencies hidden with a sledgehammer. At any rate, it makes gb_CppunitTest_use_ure even more of a misnomer.

That said, probably a sufficiently pragmatic solution, anyway.  ;)

Stephan

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.