Hi Albert,
On Mon, Apr 9, 2012 at 6:31 PM, Albert Thuswaldner
<albert.thuswaldner@gmail.com> wrote:
Hi Kohei,
As said back in February:
http://lists.freedesktop.org/archives/libreoffice/2012-February/027009.html
here is a follow-on patch that "groups" the formula options in the
same fashion as the print options.
This is a quite straight-forward re-factoring of the code so it
shouldn't be too hard to review.
I'm reviewing at the moment, but your patch doesn't apply cleanly
against latest master. Is there any way you can update your patch
against recent enough master?
If you are too busy, that's fine. I'll do my best to apply it
manually. Just let me know.
I only took a cursory look, and your use of local variable is probably
ok, though I still need to make sure that it works as
expected....(which is why I need to apply the patch and run a quick
test....)
Best,
Kohei
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.