Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

Hello Albert,

sorry that it took me some time but I had a long fight with our chart
interpolation algorithm and was not able to update my tree for more
than a week.

> > - ScSortDescriptor::FillSortParam looks like there might happen some
> > index out of bounds access
>
> So I have updated the patch with respect to your comments above and
> corrected all the issues except for the last one, which I honestly can
> not find. There are several ScSortDescriptor::FillSortParam in
> different files which are touch by my patch. So could help me pointing
> out the line(s) which you are concern about?

Reviewed and pushed your patch. Fixed the out-of bounds access in
http://cgit.freedesktop.org/libreoffice/core/commit/?id=d31f5476fddda994cad6920f7383e4c92ccac9a2

The vector::resize calls are necessary because we will now access
elements that are not in the old vector and the index access will not
create them. The sal_True to true changes are just cosmetic but when
we are already modifying these lines we can also change them. Normally
we would try to have the sal_Bool -> bool  changes separated.

> Regarding the remaining UI bits I have started to look at this and
> think I understand how to implement it. The scroll handler is still a
> mystery, see if I can figure it out.

Great. If you need help there just write a mail. The scroll handler is
really the hardest part there and we can have a look if we can borrow
the implementation from another dialog.

Regards,
Markus