Re: Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx

Ivan Timofeev <timofeev.i.s -AT- gmail.com>
Mon, 26 Mar 2012 18:03:30 +0400

Hi Julien,

On 24.03.2012 03:26, julien2412 wrote:

Just for the update, is there anybody who could help about this ?

I am not expert, too, but looking at vcl/source/gdi/sallayout.cxx:115and http://www.unicode.org/charts/PDF/UFF00.pdf I'd say that thecondition should be at least

  (nChar >= 0xff5b && nChar < 0xff64 )
                ^

However, I do not know why this implementation (in text_gfx.cxx) differsfrom sallayout.cxx.


Regards,
Ivan

Context

Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx · julien2412
- Re: Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx · Stephan Bergmann
  - Re: Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx · julien2412
    - Re: Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx · Stephan Bergmann
      - Re: Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx · julien2412
        
        Re: Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx · Ivan Timofeev
        
        Re: Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.