Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hello,

Cppcheck reports this :
[generic/print/text_gfx.cxx:105]: (warning) Logical conjunction always
evaluates to false: nChar < 65380 && nChar >= 65387

Here are the lines :
   103         if( ( nChar >= 0x3008 && nChar < 0x3019 && nChar != 0x3012 )
||
    104             nChar == 0xff3b || nChar == 0xff3d ||
    105             (nChar >= 0xff6b && nChar < 0xff64 ) ||
    106             nChar == 0xffe3
    107             )
    108             nAngle = 0;

Shoud the line 105 just be replaced by :
 (nChar >= 0xff64 && nChar < 0xff6b ) ||

Or is it less obvious/more tricky than that ?

If ok, I can commit and push it on master of course.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-reports-Logical-conjunction-always-evaluates-to-false-in-text-gfx-cxx-tp3836511p3836511.html
Sent from the Dev mailing list archive at Nabble.com.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.