Re: [PATCH] [PUSHED] Windows lcms2 library import fix

On Monday 19 of March 2012, Stephan Bergmann wrote:
> On 03/19/2012 08:58 AM, Tor Lillqvist wrote:
> > Pushed your patch, with a clarification of the comment.
>
> This at least breaks my local MinGW build in lcms2:
> > /bin/sh ../libtool --tag=CC   --mode=link i686-w64-mingw32-gcc -std=gnu99
> >  -g -O2 -no-undefined -version-info 2:3:0  -o liblcms2.la -rpath
> > /usr/local/lib cmscnvrt.lo cmserr.lo cmsgamma.lo cmsgmt.lo cmsintrp.lo
> > cmsio0.lo cmsio1.lo cmslut.lo cmsplugin.lo cmssm.lo cmsmd5.lo cmsmtrx.lo
> > cmspack.lo cmspcs.lo cmswtpnt.lo cmsxform.lo cmssamp.lo cmsnamed.lo
> > cmscam02.lo cmsvirt.lo cmstypes.lo cmscgats.lo cmsps2.lo cmsopt.lo -lm
> > libtool: link: rm -fr  .libs/liblcms2.dll.a
> > libtool: link: i686-w64-mingw32-gcc -std=gnu99 -shared  .libs/cmscnvrt.o
> > .libs/cmserr.o .libs/cmsgamma.o .libs/cmsgmt.o .libs/cmsintrp.o
> > .libs/cmsio0.o .libs/cmsio1.o .libs/cmslut.o .libs/cmsplugin.o
> > .libs/cmssm.o .libs/cmsmd5.o .libs/cmsmtrx.o .libs/cmspack.o
> > .libs/cmspcs.o .libs/cmswtpnt.o .libs/cmsxform.o .libs/cmssamp.o
> > .libs/cmsnamed.o .libs/cmscam02.o .libs/cmsvirt.o .libs/cmstypes.o
> > .libs/cmscgats.o .libs/cmsps2.o .libs/cmsopt.o    -O2   -o
> > .libs/liblcms2-2.dll -Wl,--enable-auto-image-base -Xlinker --out-implib
> > -Xlinker .libs/liblcms2.dll.a Creating library file:
> > .libs/liblcms2.dll.a.libs/cmscnvrt.o: In function
> > `BlackPreservingSampler':
> > /data/lo-mingw/core/lcms2/wntgcci.pro/misc/build/lcms2-2.3/src/cmscnvrt.c
> > :767: undefined reference to `_imp__cmsEvalToneCurveFloat@8'

 Is this when building lcms2? That one has CMS_DLL_BUILD defined, so the patch 
shouldn't change anything there. Hmm, except that this CMS_DLL_BUILD defining 
is done in MSVC project file, so I assume that's not used for gcc build. I 
suppose the lcms2 build should add -DCMS_DLL_BUILD to CPPFLAGS when not doing 
msvc build?

-- 
 Lubos Lunak
 l.lunak@suse.cz