Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi,

I would like to add an option for the paper size of 'Japanese Postcard'
[1] to combo boxes such as Paper format and Print dialog.
The attached patch against master seems sufficient for that because its
actual dimension is already defined in the code base.
But I think it would be controversial to have extra paper sizes which no
ones but only in a few locale use often.
Any thought?

[1] http://msdn.microsoft.com/en-us/library/windows/desktop/dd319099(v=vs.85).aspx

Cheers,
-- Takeshi Abe
From 09fea9e43d0ddf3b09719c140727fda9a9cba526 Mon Sep 17 00:00:00 2001
From: Takeshi Abe <tabe@fixedpoint.jp>
Date: Wed, 14 Mar 2012 02:07:36 +0900
Subject: [PATCH] add 'Japanese Postcard' paper size to both Paper format and
 Print dialog

---
 cui/source/tabpages/page.h   |    1 +
 cui/source/tabpages/page.src |    2 ++
 vcl/source/gdi/print.cxx     |    3 ++-
 vcl/source/src/print.src     |    1 +
 4 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/cui/source/tabpages/page.h b/cui/source/tabpages/page.h
index 9a6af59..bc7ad78 100644
--- a/cui/source/tabpages/page.h
+++ b/cui/source/tabpages/page.h
@@ -72,6 +72,7 @@
 #define PAPERSIZE_B4_JIS        34
 #define PAPERSIZE_B5_JIS        35
 #define PAPERSIZE_B6_JIS        36
+#define PAPERSIZE_POSTCARD_JP   46
 #define PAPERSIZE_A6            56
 
 #endif
diff --git a/cui/source/tabpages/page.src b/cui/source/tabpages/page.src
index b1bf107..91873c7 100644
--- a/cui/source/tabpages/page.src
+++ b/cui/source/tabpages/page.src
@@ -418,6 +418,7 @@ StringArray RID_SVXSTRARY_PAPERSIZE_STD
         < "#10 Envelope" ; PAPERSIZE_COM10; > ;
         < "#11 Envelope" ; PAPERSIZE_COM11; > ;
         < "#12 Envelope" ; PAPERSIZE_COM12; > ;
+        < "Japanese Postcard" ; PAPERSIZE_POSTCARD_JP; > ;
     };
 };
 StringArray RID_SVXSTRARY_PAPERSIZE_DRAW
@@ -452,6 +453,7 @@ StringArray RID_SVXSTRARY_PAPERSIZE_DRAW
         < "C4 Envelope" ; PAPERSIZE_C4 ; > ;
         < "Dia Slide" ; PAPERSIZE_DIA ; > ;
         < "Screen" ; PAPERSIZE_SCREEN ; > ;
+        < "Japanese Postcard" ; PAPERSIZE_POSTCARD_JP; > ;
     };
 };
  // ********************************************************************** EOF
diff --git a/vcl/source/gdi/print.cxx b/vcl/source/gdi/print.cxx
index e25aa3a..90e8403 100644
--- a/vcl/source/gdi/print.cxx
+++ b/vcl/source/gdi/print.cxx
@@ -1267,7 +1267,8 @@ rtl::OUString Printer::GetPaperName( Paper ePaper )
                 PAPER_ENV_DL, PAPER_SLIDE_DIA, PAPER_SCREEN, PAPER_C, PAPER_D, PAPER_E,
                 PAPER_EXECUTIVE, PAPER_FANFOLD_LEGAL_DE, PAPER_ENV_MONARCH, PAPER_ENV_PERSONAL,
                 PAPER_ENV_9, PAPER_ENV_10, PAPER_ENV_11, PAPER_ENV_12, PAPER_KAI16,
-                PAPER_KAI32, PAPER_KAI32BIG, PAPER_B4_JIS, PAPER_B5_JIS, PAPER_B6_JIS
+                PAPER_KAI32, PAPER_KAI32BIG, PAPER_B4_JIS, PAPER_B5_JIS, PAPER_B6_JIS,
+                PAPER_POSTCARD_JP
             };
             OSL_ENSURE( sal_uInt32(SAL_N_ELEMENTS(PaperIndex)) == aPaperStrings.Count(), 
"localized paper name count wrong" );
             for( int i = 0; i < int(SAL_N_ELEMENTS(PaperIndex)); i++ )
diff --git a/vcl/source/src/print.src b/vcl/source/src/print.src
index e1dab96..986c381 100644
--- a/vcl/source/src/print.src
+++ b/vcl/source/src/print.src
@@ -531,6 +531,7 @@ StringArray RID_STR_PAPERNAMES
         < "B4 (JIS)"; >;
         < "B5 (JIS)"; >;
         < "B6 (JIS)"; >;
+        < "Japanese Postcard"; >;
     };
 };
 
-- 
1.7.9.1


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.