Re: String literals, ASCII vs UTF-8

Stephan Bergmann <sbergman -AT- redhat.com>

Wed, 29 Feb 2012 11:58:01 +0100

On 02/29/2012 10:57 AM, Michael Meeks wrote:

        Having said all this - I think we can agree that if we are calling this
new 'createFromAscii_WithLength' method - which is (currently) only
called during these magic constructors for compile time constants, that
the chance of having a 4Gb compile-time constant string in the source is
somewhat minimal ;-) and that there is certainly no need to throw an
exception and bloat the call-sites for this case at least.

I don't really think we can agree here. ;) As long as the "bloat" is

only alleged, I see no reason to abandon clean coding practices (i.e.,

checking C function return values for error indicators). If you are

unhappy with "throw std::bad_alloc;", maybe we can settle for

"std::abort();" instead?

Stephan

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.