Re: [REVIEW 3.5.1 (?)] fdo#46144: "Distributy Columns Evenly" does not work with the selected columns

Michael Meeks <michael.meeks -AT- suse.com>
Mon, 27 Feb 2012 16:15:03 +0000


On Mon, 2012-02-27 at 19:46 +0400, Ivan Timofeev wrote:

On 27.02.2012 19:01, Michael Meeks wrote:

    Having said that I'm not hyper-happy with not initialising the vector's
contents - don't we really want:

    std::vector<sal_uInt16>  aWish( aTablCols.Count() + 1, 0 ),
                            aMins( aTabCols.Count() + 1, 0 );

...

— otherwise, the storage for the object is zero-initialized.


        Fair enough :-) Patch looks great then, one more ack needed for 3.5.1.

        Thanks,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot

Context

[REVIEW 3.5; 3.5.1 (?)] fdo#46144: "Distributy Columns Evenly" does not work with the selected columns · Ivan Timofeev
- Re: [PUSHED 3-5] [REVIEW 3.5; 3.5.1 (?)] fdo#46144: "Distributy Columns Evenly" does not work with the selected columns · Norbert Thiebaud
  - Re: [PUSHED 3-5] [REVIEW 3.5; 3.5.1 (?)] fdo#46144: "Distributy Columns Evenly" does not work with the selected columns · Korrawit Pruegsanusak
  - [REVIEW 3.5.1 (?)] fdo#46144: "Distributy Columns Evenly" does not work with the selected columns · Michael Meeks
    - Re: [REVIEW 3.5.1 (?)] fdo#46144: "Distributy Columns Evenly" does not work with the selected columns · Ivan Timofeev
      - Re: [REVIEW 3.5.1 (?)] fdo#46144: "Distributy Columns Evenly" does not work with the selected columns · Michael Meeks
        
        Re: [PUSHED][REVIEW 3.5.1 (?)] fdo#46144: "Distributy Columns Evenly" does not work with the selected columns · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.