Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index



On Mon, 2012-02-27 at 00:53 -0600, Norbert Thiebaud wrote:
Fixed invalid conversion from SvUShorts to std::vector... *sigh*
Please, pick to the appropriate branches.

I pushed it on the 3.5 branch.

        With one more review (preferably from a writer maintainer) we're good
for 3.5.1 I think. RC2 is final though Ivan - so we're trying to reduce
the number of patches between RC1 and final of our point releases.

        Having said that I'm not hyper-happy with not initialising the vector's
contents - don't we really want:

        std::vector<sal_uInt16> aWish( aTablCols.Count() + 1, 0 ),
                                aMins( aTabCols.Count() + 1, 0 );

        The previous Max() of the count with 255 looks somewhat odd /
disturbing - no idea what horrors that might hide ;-) sadly that sort of
thing has been there since the beginning.

        Anyhow - thanks for fixing the bug !

        Regards,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.