Re: [REVIEWED] glib needed only when enable_librsvg, gettext only when enable_librsvg or cross-compile

Hello Michael,

[re-adding the list in cc, sorry for missing]

On Tue, Feb 21, 2012 at 22:20, Michael Meeks <michael.meeks@suse.com> wrote:
> On Tue, 2012-02-21 at 21:32 +0700, Korrawit Pruegsanusak wrote:
> > >        I don't think you need to worry about that in scp2; your patch looks
> > > fine. Can you push it ? :-)
> >
> > If so, may I move the #if ENABLE_LIBRSVG upper to also guard 'gettext'?
>
>        Yes - makes perfect sense if the two are slaved. IIRC there was some
> hope to use gettext for translation of strings at run-time, I don't
> think we managed to get that to work in the end [ very odd threading
> behaviour ].
>
> > ie, may I move #if ENABLE_LIBRSVG to before line #1605?
>
>        Do what you think best ! :-) we can always try to unwind it afterwards
> if there is some hideous problem we find later.

Done :-)
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e10aed115b5c861e0e639d374c54b3d0b760502e

Best Regards,
-- 
Korrawit Pruegsanusak