Hi Philipp Thanks for your response and your hints on how to contribute - I'll keep that in mind for future contributions :) And also thanks for the review! -- Dave On 17/02/12 18:02, Philipp Weissenbacher wrote:
Hello you two! Thanks for the big amount of work. I know how tiresome it is to translate this oververbose German to something that makes sense in English. That and the technical jargon make translating it quite time intensive. So kudos for that much work! I think that it'd be much easier to review your patches and get them integrated quicker if you post fewer of them and at an earlier stage. Every little step counts and is appreciated :). I usually try to keep under 50 K per patch - which makes for quite a few small files or one large one with some smaller ones. I saw that you also added TODO comments about the translation. That's not very handy, as I cannot communicate with you about it :-). It'd be nicer to either include the comment in the patch email or ask on IRC. I noticed a lot of trailing whitespace errors. I had the same problem in the beginning too, just find a plugin for your editor that removes them for you or (if you use vim) you can add autocmd BufWritePre * :%s/\s\+$//e to your ~/.vimrc file (see http://vim.wikia.com/wiki/Remove_unwanted_spaces). I would greatly appreciate it if you could do that for any future work. Then I don't have to fix them when reviewing. :-). BTW: I'm reviewing the first five patches. Cheers, Philipp 2012/2/16 David Vogt <david.vogt@adfinis-sygroup.ch>:Hi everybody As Nicolas Christener and I promised to Cedric at FOSDEM, we set sail to translate the german comments in the sw/source/core/layout/ directory. We're still not quite done, but here's what we have so far. This, and any future contributions to LibreOffice are available under the MPL / LGPLv3+ unless stated otherwise. As far as I know, Nicolas has already sent his license statement, Stefan will follow soon. Since we're not very familiar with the code, it may well be that there are conceptual mistakes in our translation, so read with care ;) -- Dave -- Adfinis SyGroup AG David Vogt, Software Engineer / Project Manager Keltenstrasse 98 | CH-3018 Bern Tel. 031 381 70 47 | Direct 031 550 31 12 _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
-- Adfinis SyGroup AG David Vogt, Software Engineer / Project Manager Keltenstrasse 98 | CH-3018 Bern Tel. 031 381 70 47 | Direct 031 550 31 12
Attachment:
signature.asc
Description: OpenPGP digital signature