splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

Ivan Timofeev <timofeev.i.s -AT- gmail.com>
Sat, 18 Feb 2012 17:41:48 +0400

On 18.02.2012 17:29, Mariusz Dykierek wrote:

I have a 'replacement' patch that actually replaces most of if...else if...else chains with
switches.


Great!

They are more legible and seem natural when choosing branches depending on the same variable.

On the other hand, the evaluated expression is not visible at thefirst-look... A lot of people - a lot of opinions :)

Question I have, is how do I submit the patch:
  - as a reply to this thread, or
  - a new patch in a new thread?

I think, if a patch extends or replaces a current one - submit as areply, otherwise - start a new thread.


Cheers,
Ivan

Context

[PATCH] [core/vcl/source/window/splitwin.cxx:2047] -> [core/vcl/source/window/splitwin.cxx:2045]: (style) Found duplicate branches for if and else. · Mariusz Dykierek
- Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] -> [core/vcl/source/window/splitwin.cxx:2045]: (style) Found duplicate branches for if and else. · Riccardo Magliocchetti
  - Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] -> [core/vcl/source/window/splitwin.cxx:2045]: (style) Found duplicate branches for if and else. · Stephan Bergmann
    - Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] -> [core/vcl/source/window/splitwin.cxx:2045]: (style) Found duplicate branches for if and else. · Mariusz Dykierek
      - Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else. · Matteo Casalin
        
        Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else. · Stephan Bergmann
        
        Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else. · Mariusz Dykierek
        
        Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else. · Ivan Timofeev
        Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else. · Mariusz Dykierek
        [PUSHED] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else. · Michael Meeks
        
        Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else. · julien2412
        Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else. · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.