Re: [PATCH] Remove unused code from gtkframe

On 15/02/12 21:31, Kate Goss wrote:
> Hi Michael, Caolan,
>
> How accurate/ up to date is unusedcode.easy? Is there a way to make sure
> the methods I'm removing are genuinely unused?

the problem is that unusedcode.easy is generated from a single
configuration of LO.  because there is a huge number of potential
configurations, there may be some false positives, especially in modules
that are highly platform dependent, such as "vcl", "tools", "sal" or
"extensions".

> Am I just doing it wrong and removing the wrong things? : )

you could try to "git grep" for the function you want to remove, and see
if there's anything that calls it behind some #ifdef or in some platform
specific code, but it's not a huge problem if you miss something, that's
why we review patches :)

regards,
 michael