Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi there,

        Alexander just removed a load of gcc conditionals from master, but
there were a few I dropped from his patch to get some further input from
you.

        We've decided (I think) in
https://bugs.freedesktop.org/show_bug.cgi?id=45131 that 4.0.1

* cppu/inc/cppu/macros.hxx:
        CPPU_GCC3_ALIGN - uh ?

        I assume this should be just CPPU_GCC_ALIGN and with only one
definition in today's world ?

* sal/inc/rtl/instance.hxx:
        #if (__GNUC__ >= 4)

        Do we need all those conditionals ? or do we want a

        #if defined (__GCC__) there ?

* sal/inc/sal/config.h

        We have a conditional for SAL_ISO_CONST, but do we ever even use that
thing ? :-) if not, can we just drop it ? breaks source compat, but ...
if we didn't use it ;-)

        Overall, it's quite encouraging to see the improving C++ support of
gcc, and the ripping out of lots of legacy awfulness to work around it.

        Thanks :-)

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.