Re: [Libreoffice] [Pushed] [PATCH]Bug 34425 - [EasyHack] formatting background color toolbar button

Muthu Subramanian K <sumuthu -AT- suse.com>
Wed, 01 Feb 2012 13:26:50 +0530

Marking this as pushed. I pushed it as two different patches - one for
the translations and the other the easyhack. Thank you for the patches
(I really liked the new behavior of the button). And sorry for the delay.
Some nitpicking:
- It would be great if you could use expand tabs (i.e. spaces instead of
tabs).

@ux-advise: It would be great if you guys could review the new behavior
of the button, please?

PS: I haven't thoroughly reviewed the patch, it would be great if
somebody else could review it as well. Thanks! [Eike or Kohei?]

commit:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4daa3f54437730fe4e509082faa0d3509c62cea0

Thanks!
Muthu Subramanian

On 01/21/2012 04:10 PM, Winfried Donkers wrote:

Attached the patch for fdo34425.
Also, I translated the german comments in tbcontrl.hxx (plus corrected one typing error in it)

Winfried



_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Context

[Libreoffice] [PATCH]Bug 34425 - [EasyHack] formatting background color toolbar button · Winfried Donkers
- Re: [Libreoffice] [Pushed] [PATCH]Bug 34425 - [EasyHack] formatting background color toolbar button · Muthu Subramanian K
  - [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button · Winfried Donkers
    - Re: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button · Jan Holesovsky
      - Re: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button · Winfried Donkers
        
        Re: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button · Jan Holesovsky
        
        Re: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button · Stefan Knorr (Astron)
        
        Re: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button · Jan Holesovsky
        
        RE: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button · Winfried Donkers
        Re: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button · Stefan Knorr (Astron)
        RE: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button · Winfried Donkers
        Re: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button · Ivan Timofeev

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.