Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On Tue, 2012-01-31 at 20:07 +0000, Noel Power wrote:
> On 31/01/12 18:35, Albert Thuswaldner wrote:
> > > Additionally you still can get the prefix name to
> > > >  be blank ( or at least I managed to do that ) by attempting to change the
> > > >  name by delete, when all the name is deleted you get a message saying the
> > > >  sheet prefix is illegal ( actually I find that behaviour annoying e.g. I
> > > >  would prefer/expect the error after I press ok ) And if fact with the blank
> > > >  ( from the error scenario above ) you can press ok and now the default
> > > >  prefix is blank:-)
> > For me allowing a blank prefix is a feature and not a bug!
> :-) well, I guess one of the calc experts might have an opinion on that. 

Honestly, no clue whether an empty sheet prefix is truly a problem or
not.  We can certainly experiment it and if that's indeed a problem we
can add that check back in.  I would think that, as long as the actual
sheet name is not empty, it *should* probably be okay.

> Personally I would not check every keypress, an alternative would be to 
> check the prefix when you press 'ok' and if it is illegal then don't 
> close the option dialog but instead restore the previous 'legal' entry ( 
> selecting the entry probably is an idea also ) and raise the error 
> dialog ( but there are other workflows I suppose )

Well, that's rather hard to do with the Options dialog, since you can
freely switch between different option pages and we then would have to
check the validity of all the option tab pages upon dismissal of the
whole Options dialog...  I've been on that boat before, and it's very
tricky to implement.  Especially when two or more option pages want to
throw an error dialog, you may end up with lots of error dialogs when
clicking OK.

Given that, I still think it's better (and easier) to check for every
key-press, but instead of launching an error dialog for an illegal name,
just put the old legal name back into the text box and sound an beep or
something.  That's less intrusive than a big dialog being thrown right
in your face.  I do exactly that for the argument separator value inputs
in the Formula option page.

But that's not really a big issue and I (or someone else) can fix that
later once the craze of 3.5 bug fixing becomes less intense.

Just my 2-cents.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc