Re: [Libreoffice] [PUSHED][3.5][3.5.0] fix for fdo#44836 (leaking page breaks)

Michael Meeks píše v Út 31. 01. 2012 v 15:56 +0000:
> On Tue, 2012-01-31 at 15:48 +0100, Cedric Bosdonnat wrote:
> > I just fixed some remaining leaking page breaks. Could someone review
> > and cherry-pick it for 3.5 (and hopefully it's not too late for 3.5.0)?
> >
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=9babbf346c4d6f76e8b3a243a00e73a173c16ba6
>
>       Well; it looks conceptually reasonable to me. I hope that VCL will not
> do slowish X stuff for the hide if it is already hidden, and vv. for the
> Show. Did you test with a few hundred pages ?
>
>       If so, I'm happy I guess ;-) thanks for fixing my pet hate.

I played with a big document. The patch definitely improved the
behavior. I did not see any evident problem. The patch looked
reasonable. Michael Stahl confirmed that it should not cause any evident
crash => I pushed it into both 3-5 and 3-5-0 branches.


Best Regards,
Petr