Re: [Libreoffice] Same expression on both sides of '||' in svtools/source/filter/sgvtext.cxx

Eike Rathke <erack -AT- redhat.com>

Mon, 30 Jan 2012 21:11:41 +0100

Hi julien2412, On Monday, 2012-01-30 11:24:18 -0800, julien2412 wrote:

    139 #define  EscSet    '' /* Flag setzen                                              
*/

Now why EscSet = EscReset = EscToggl ?
I took a look at the git history and found the commit
9e5584a82633442467a53ccc08c3380070178a38 included something about "EscSet".
I tried to copy paste here to show you and had empty values (whereas it's
not empty at all !) :
+ #define  EscSet    '' /* Flag setzen                                              
*/
+ #define  EscReset  '' /* Flag loeschen                                            
*/
+ #define  EscDeflt  '\x11' /* Flag auf default setzen                               
*/
+ #define  EscToggl  '' /* Flag Toggeln                                             
*/

Special characters/encoding problem ?

Yeah, great, literal control characters in source code :-/ These should be #define EscSet '\x1e' #define EscReset '\x1f' #define EscDeflt '\x11' #define EscToggl '\x1d' Good catch! Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD

Attachment: pgpKgEbpJUmG3.pgp
Description: PGP signature

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.