On Mon, 2012-01-30 at 19:22 +0100, Lubos Lunak wrote:
The regression is caused by commit 8434a6966914547451489db6828b31ae86901186,
which added size checks, but incorrectly - remainingSize() is called before
the seek to the right position is done, which occassionally makes the code
believe the file is corrupt.
I don't actually know the format enough to be certain about the fix, but I
expect it is quite clear from the logic of the thing, so I've committed as
b5a73d4b2b283d3d1a57ac0f66b608998960a873 . Please review and backport.
Looks lovely to me; pushed to -3-5, Caolan are you happy for 3.5.0 ? we
had busted comment interop with .docx in 3.4 (so people used .doc) :-)
ATB,
Michael.
--
michael.meeks@suse.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.