Re: [Libreoffice] [REVIEWED 3-5, 3-5-0] The type-detection of extension-less documents is broken

Cedric Bosdonnat <cbosdonnat -AT- suse.com>
Thu, 26 Jan 2012 17:27:08 +0100

Hello Fridrich,

On Thu, 2012-01-26 at 14:40 +0100, Fridrich Strba wrote:

This patch:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d9aa8cce792d69d5147a2230b61b1cbdc089206

fixes a bug where the catch-all type detector was called first in the 
list of type detectors when an extension-less document was passed. This 
caused quite a number of macintosh documents to be mis-detected as 
encoded text.


The patch looks good to me. If you tested it with several files, it's ok
for me for 3.5.0. I just cherry-picked it in -3-5-0.

--
Cedric

Context

[Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken · Fridrich Strba
- Re: [Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken · Fridrich Strba
- Re: [Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken · Michael Meeks
  - Re: [Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken · Fridrich Strba
  - [Libreoffice] [REVIEWED][REVIEW 3-5, 3-5-0] The type-detection of extension-less documents is broken · Caolán McNamara
    - Re: [Libreoffice] [REVIEWED][REVIEW 3-5, 3-5-0] The type-detection of extension-less documents is broken · Michael Meeks
- Re: [Libreoffice] [REVIEWED 3-5, 3-5-0] The type-detection of extension-less documents is broken · Cedric Bosdonnat
  - Re: [Libreoffice] [PUSHED][REVIEWED 3-5, 3-5-0] The type-detection of extension-less documents is broken · Eike Rathke
- Re: [Libreoffice] [REVIEWED 3-5, 3-5-0] The type-detection of extension-less documents is broken · Lionel Elie Mamane

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.