Re: [Libreoffice] .: sal/inc sal/osl

On 23/01/12 10:03, Petr Mladek wrote:
> Michael Meeks píše v Pá 20. 01. 2012 v 17:34 +0000:
> > On Fri, 2012-01-20 at 17:06 +0100, Michael Stahl wrote:
> > > > +#if defined(__GNUC__) && (__GNUC__ < 3)
> > > > +    struct ::stat a_stat, b_stat;
> > > > +#else
> > > > +    struct stat a_stat, b_stat;
> > > > +#endif
> > >
> > > do we really need to have ifdefs for GCC 2 in LO?
> >
> >      Probably not :-) I just re-used what was there already to avoid causing
> > even more novel problems :-)
> >
> >      I suspect we can rid ourselves of gcc2 everywhere (as an easy hack ?)
> > but I'd prefer to have Petr check whatever ultra-old systems we build
> > for ;-)
>
> The oldest system, we use, is SLED10 with gcc-4.1.2.
> Also we use gcc-4.2.4 for the official LO builds for TDF.

ah, yes, that's about what i expected; also, for MacOSX gcc 4.0.1 is
used, which is AFAIK the oldest one.

> So, I think that it is perfectly fine to remove support for GCC 2.

i'd be very, very surprised if anything older than 4.0.1 still builds at
all (and even that one is annoying with it's spurious uno::Any
warnings), so there's some cleanup potential here.