Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn

Kohei Yoshida <kohei.yoshida -AT- suse.com>
Fri, 20 Jan 2012 17:19:06 -0500

Hi Noel,

On Sat, 2012-01-21 at 00:01 +0200, Noel Grandin wrote:

I hereby confirm that this and my future contributions are licensed
under GPLv3+/LGPLv3+/MPL1.1+


Thanks for the confirmation.  Just pushed to master, with my follow-up
changes (as I mentioned in my earlier post).

The problem was in ScColumn::Resize
I was calling vector::resize when the correct call is vector::reserve


Ah! Ok.  I didn't spot that either.  Good catch.

At some point I should rename the ScColumn::Resize method to match the
std::vector naming


Yup.  That makes sense.  No objection with that.

Regards,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

Context

[Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn · Noel Grandin
- Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn · Kohei Yoshida
  - Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn · Noel Grandin
    - Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn · Kohei Yoshida

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.