Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn

I hereby confirm that this and my future contributions are licensed
under GPLv3+/LGPLv3+/MPL1.1+

The problem was in ScColumn::Resize
I was calling vector::resize when the correct call is vector::reserve

At some point I should rename the ScColumn::Resize method to match the
std::vector naming

-- Noel Grandin

On Fri, Jan 20, 2012 at 19:07, Kohei Yoshida <kohei.yoshida@suse.com> wrote:
> On Fri, 2012-01-20 at 15:15 +0200, Noel Grandin wrote:
> > Hi
> >
> > this patch passes valgrind tests in the sc module, and passes a global
> > make check.
>
> Yup.  All looks green.  Nice work. :-)
>
> Before I push, could you verify that you are submitting this patch under
> GPLv3+/LGPLv3+/MPL1.1+ licenses?
>
> Out of curiosity, what was the problem that was causing the unit test to
> fail with your earlier patch?
>
> Best,
>
> Kohei
>
> --
> Kohei Yoshida, LibreOffice hacker, Calc
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice