Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On 12/01/12 16:55, Noel Power wrote:
Be good to get this in, afaict this shouldn't cause any problems
see attached patch

Noel

looking at the change, i notice that now it is independent of the
operation being performed, while the code that was originally removed in
adcba12537d047f5ad65334b65512615311cf872 checked for addition only (as
the comment says):

-                    // #45465 Date needs with "+" a special handling
-                    if( eOp == SbxPLUS && (GetType() == SbxDATE || rOp.GetType() == SbxDATE ) )
-                        aL.eType = SbxDATE;

is that intentional?

i'm +1 for putting the original change back, and perhaps also for your
changed variant if you have a good explanation :)


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.