[Libreoffice] [PATCH] fdo#44616 - webkit won't render frames of table borders of Calc/HTML

Hi all,

Let me propose a patch to fix fdo#44616 for master branch by abandoning
attributes FRAME and RULES of TABLE element in .html.
I found that .html output is declared as HTML 3.2, though neither of these
attributes are explicitly defined in [1].

On the other hand, as mentioned in HTML 4.01 specification [2], just remaining
BORDER="0" should work in terms of backward compatibility.
Any suggestion and/or review would be appreciated.

[1] http://www.w3.org/TR/REC-html32
[2] http://www.w3.org/TR/html401/struct/tables.html#h-11.3.1

Cheers,
-- Takeshi Abe

From 483ad8744269ec31f6cca773840f5b8f9c53e522 Mon Sep 17 00:00:00 2001
From: Takeshi Abe <tabe@fixedpoint.jp>
Date: Wed, 11 Jan 2012 01:28:29 +0900
Subject: [PATCH] drop attributes FRAME and RULES of <table> for HTML 3.2

This fixes fdo#44616.
HTML 3.2 does not have these attributes:
http://www.w3.org/TR/REC-html32
---
 sc/source/filter/html/htmlexp.cxx |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/sc/source/filter/html/htmlexp.cxx b/sc/source/filter/html/htmlexp.cxx
index c48c570..ec550e2 100644
--- a/sc/source/filter/html/htmlexp.cxx
+++ b/sc/source/filter/html/htmlexp.cxx
@@ -736,11 +736,6 @@ void ScHTMLExport::WriteTables()
         // <TABLE ...>
         rtl::OStringBuffer aByteStrOut(OOO_STRING_SVTOOLS_HTML_table);
 
-        // FRAME=VOID, we do the styling of the cells in <TD>
-        aByteStrOut.append(' ').append(OOO_STRING_SVTOOLS_HTML_frame).
-            append(RTL_CONSTASCII_STRINGPARAM("=\"")).
-            append(OOO_STRING_SVTOOLS_HTML_TF_void).append('"');
-
         bTabHasGraphics = bTabAlignedLeft = false;
         if ( bAll && pDrawLayer )
             PrepareGraphics( pDrawLayer, nTab, nStartCol, nStartRow,
@@ -770,11 +765,6 @@ void ScHTMLExport::WriteTables()
             append(RTL_CONSTASCII_STRINGPARAM("=\"")).
             append(static_cast<sal_Int32>(nColCnt)).append('"');
 
-        // RULES=NONE, we do the styling of the cells in <TD>
-        aByteStrOut.append(' ').append(OOO_STRING_SVTOOLS_HTML_O_rules).
-            append(RTL_CONSTASCII_STRINGPARAM("=\"")).
-            append(OOO_STRING_SVTOOLS_HTML_TR_none).append('"');
-
         // BORDER=0, we do the styling of the cells in <TD>
         aByteStrOut.append(' ').append(OOO_STRING_SVTOOLS_HTML_O_border).
             append(RTL_CONSTASCII_STRINGPARAM("=\"0\""));
-- 
1.7.7.3