Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Tue, 2012-01-03 at 20:05 +0100, Eike Rathke wrote:
Hi julien2412,

On Wednesday, 2011-12-28 13:13:43 -0800, julien2412 wrote:

On cppcheck report, there were 2 "Same expression on both sides of '&&'" on 
b2dpolypolygoncutter.cxx

I don't know how this part works so I recognize it's just guessing.

diff --git a/basegfx/source/polygon/b2dpolypolygoncutter.cxx
b/basegfx/source/polygon/b2dpolypolygoncutter.cxx
index d32ee87..8745241 100644
--- a/basegfx/source/polygon/b2dpolypolygoncutter.cxx
+++ b/basegfx/source/polygon/b2dpolypolygoncutter.cxx
@@ -282,7 +282,7 @@ namespace basegfx
                                 bOnEdge = false;
                             }
                         }
-                        while(bOnEdge && pPNa2 != &rPNa && pPNa2 != &rPNa);
+                        while(bOnEdge && pPNa2 != &rPNa && pPNb2 != &rPNb);
 
                         if(bOnEdge)
                         {
@@ -408,7 +408,7 @@ namespace basegfx
                                 bOnEdge = false;
                             }
                         }
-                        while(bOnEdge && pPNa2 != &rPNa && pPNa2 != &rPNa);
+                        while(bOnEdge && pPNa2 != &rPNa && pPNb2 != &rPNb);
 
                         if(bOnEdge)
                         {

Does it seem ok ? (If yes, I can commit and push it on master branch)

I think so, but I'm not sure either. Anyone with a second opinion?

Change seems reasonable to me FWIW, presumably Thorsten knows best what
basegfx wants to do here.

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.