Hi julien2412, On Wednesday, 2011-12-28 13:13:43 -0800, julien2412 wrote:
On cppcheck report, there were 2 "Same expression on both sides of '&&'" on
b2dpolypolygoncutter.cxx
I don't know how this part works so I recognize it's just guessing.
diff --git a/basegfx/source/polygon/b2dpolypolygoncutter.cxx
b/basegfx/source/polygon/b2dpolypolygoncutter.cxx
index d32ee87..8745241 100644
--- a/basegfx/source/polygon/b2dpolypolygoncutter.cxx
+++ b/basegfx/source/polygon/b2dpolypolygoncutter.cxx
@@ -282,7 +282,7 @@ namespace basegfx
bOnEdge = false;
}
}
- while(bOnEdge && pPNa2 != &rPNa && pPNa2 != &rPNa);
+ while(bOnEdge && pPNa2 != &rPNa && pPNb2 != &rPNb);
if(bOnEdge)
{
@@ -408,7 +408,7 @@ namespace basegfx
bOnEdge = false;
}
}
- while(bOnEdge && pPNa2 != &rPNa && pPNa2 != &rPNa);
+ while(bOnEdge && pPNa2 != &rPNa && pPNb2 != &rPNb);
if(bOnEdge)
{
Does it seem ok ? (If yes, I can commit and push it on master branch)
I think so, but I'm not sure either. Anyone with a second opinion? Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
Attachment:
pgpeln9wc7fA2.pgp
Description: PGP signature