Re: [Libreoffice] [PATCH 3/8][PUSHED] Easyhack fdo#38831 remove SvStrings

On Saturday 31 of December 2011, Brad Sowden wrote:
> On 12/29/2011 10:26 PM, Brad Sowden wrote:
> > Hi,
> >
> > See attached.
>
> Actually, this patch causes "make dev-install -o build" to fail. I have
> no idea why as the patch looks extremely innocent.
>
> If I drop this patch (and patch 8 which removes the SvStrings
> definition) then everything else applies correctly and "make dev-install
> -o build" succeeds.

-    for(i = 0; i < aFldNames.Count();i++)
+    for(std::vector<String*>::const_iterator it(aFldNames.begin()); it != 
aFldNames.end(); ++it)
     {
-        pArray[i] = *aFldNames.GetObject(i);
+        pArray[i] = **it;

               ^^^

+        delete *it;
     }

 Fixed, pushed.

-- 
 Lubos Lunak
 l.lunak@suse.cz