Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Saturday 31 of December 2011, Brad Sowden wrote:
On 12/29/2011 10:26 PM, Brad Sowden wrote:
Hi,

See attached.

Actually, this patch causes "make dev-install -o build" to fail. I have
no idea why as the patch looks extremely innocent.

If I drop this patch (and patch 8 which removes the SvStrings
definition) then everything else applies correctly and "make dev-install
-o build" succeeds.

-    for(i = 0; i < aFldNames.Count();i++)
+    for(std::vector<String*>::const_iterator it(aFldNames.begin()); it != 
aFldNames.end(); ++it)
     {
-        pArray[i] = *aFldNames.GetObject(i);
+        pArray[i] = **it;

               ^^^

+        delete *it;
     }

 Fixed, pushed.

-- 
 Lubos Lunak
 l.lunak@suse.cz

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.