Re: [Libreoffice] [PUSHED] Re: [PATCH] fdo#38832 Replace ScChangeActionTable with std::map.

Marcel Metz <mmetz -AT- adrian-broher.net>
Wed, 21 Dec 2011 21:10:54 +0100

On 21.12.2011 20:27, Michael Stahl wrote:


pushed to master, with 2 small corrections:

this here inverted the logic, Get == 0 means not found:
-   if ( p != pAct && !rTable.Get( p->GetActionNumber() ) )
+   if ( p != pAct && rMap.find( p->GetActionNumber() ) != rMap.end() )

and in ScChangeTrack::Reject, the old code iterated from end to start
(dunno if that is important there, but why not use a reverse_iterator)

thanks for the patch!


Thanks for the review. You're right, the reverse_iterator is closer to
the old behaviour.

regards Marcel

Context

[Libreoffice] [PATCH] fdo#38832 Replace ScChangeActionTable with std::map. · Marcel Metz
- [Libreoffice] [PUSHED] Re: [PATCH] fdo#38832 Replace ScChangeActionTable with std::map. · Michael Stahl
  - Re: [Libreoffice] [PUSHED] Re: [PATCH] fdo#38832 Replace ScChangeActionTable with std::map. · Eike Rathke
  - Re: [Libreoffice] [PUSHED] Re: [PATCH] fdo#38832 Replace ScChangeActionTable with std::map. · Marcel Metz
- Re: [Libreoffice] [PATCH] fdo#38832 Replace ScChangeActionTable with std::map. · Eike Rathke
  - Re: [Libreoffice] [PATCH] fdo#38832 Replace ScChangeActionTable with std::map. · Marcel Metz
    - Re: [Libreoffice] [PATCH] fdo#38832 Replace ScChangeActionTable with std::map. · Eike Rathke
- [Libreoffice] [PATCH] c1db721 ScChangeActionTable conversion: Yet another correction. · Marcel Metz
  - Re: [Libreoffice] [PUSHED][PATCH] c1db721 ScChangeActionTable conversion: Yet another correction. · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.