Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


On 21/12/11 16:18, Marcel Metz wrote:
Hello lo-devs,

I've tested the patch with 'make check', but would like to point out
that the reviewer should take special care of the change in
'sc/source/core/tool/chgtrack.cxx:3140-3160'. From my understanding
of the code the tools Table does not allow multiple entires with the
same key so that this assertion for double keys is not required but
maybe I'm missing something.

i got the same understanding: Insert method does not insert duplicates
(and i read that std::map does the same).

pushed to master, with 2 small corrections:

this here inverted the logic, Get == 0 means not found:
-   if ( p != pAct && !rTable.Get( p->GetActionNumber() ) )
+   if ( p != pAct && rMap.find( p->GetActionNumber() ) != rMap.end() )

and in ScChangeTrack::Reject, the old code iterated from end to start
(dunno if that is important there, but why not use a reverse_iterator)

thanks for the patch!


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.