Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part IX getLength() to isEmpty()

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Ivan

Em 17-12-2011 10:39, Ivan Timofeev escreveu:
> 15.12.2011 05:18, Olivier Hallot пишет:
> > Please find attached a partial fix for Easy Hack FDO43460
> >
> > Part IX
> > Module
> > connectivity
> >
> > (this one is quite big)
>
> it seems that you forgot to change the second condition:
> -            if ( !pMasterFields->getLength() ||
> !pDetailFields->getLength() )
> +            if ( pMasterFields->isEmpty() || !pDetailFields->getLength() )
>
> I changed !pDetailFields->getLength() to pDetailFields->isEmpty() and
> pushed:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=1777c09a0781710c309e500f680e6f95c080ca86
>
>
> and also:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=198a99861e14cf5c001177b1192cebfe4708ea05
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=d18daeff771b255207bb30d428540d9ebd28ec32
>
>
> Don't shy to make such trivial fixes in lines that you modify! ;)
>
> Thank you,
> Ivan

Thanks for reviewing it. I missed this one. I do a build and then a git
diff check before commiting. Naturally this is a task where mistakes can
be made easily and I am glad a second pair of eyes are there to catch them!

Kind regards
- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJO7JqOAAoJEJp3R7nH3vLxHvsH/0Pdgl38w3BEkyOQzZ7t4Yih
6oio5LS1f/Eiijl/gdmLrZwk7S5dyBCwYOMSl0cbGy7D/2M+hO2f3gmBOULmY3JT
/khPPfohpy7qpWRsQo7FX3DpBOG1jgHa6+Pqj6FKYSnK/YnOZtfeNyQhiN11OMGc
BemwspoFtuixqQS7X1aFuM0bYBJSMBv76fk8zwPsSClosYcAYWoVfihjbFDPCB3P
vZ/v9qa9JVWUQ/3/xmh3dXlVS4LamEq+etzfOB8B7EM2DCZ1f/LfY1PhxIRueVk1
bYfLOqUBIoAn9xn2QA0ZbNGRpVQzZdHanPHVqYHmWzxX2Ib8ysiX8wk0tdDB3GY=
=/2s/
-----END PGP SIGNATURE-----