Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part IX getLength() to isEmpty()

Ivan Timofeev <timofeev.i.s -AT- gmail.com>

Sat, 17 Dec 2011 16:39:13 +0400

15.12.2011 05:18, Olivier Hallot пишет:

Please find attached a partial fix for Easy Hack FDO43460

Part IX
Module
connectivity

(this one is quite big)

it seems that you forgot to change the second condition:

- if ( !pMasterFields->getLength() ||

!pDetailFields->getLength() )

+ if ( pMasterFields->isEmpty() || !pDetailFields->getLength() )

I changed !pDetailFields->getLength() to pDetailFields->isEmpty() and

pushed:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1777c09a0781710c309e500f680e6f95c080ca86 and also: http://cgit.freedesktop.org/libreoffice/core/commit/?id=198a99861e14cf5c001177b1192cebfe4708ea05 http://cgit.freedesktop.org/libreoffice/core/commit/?id=d18daeff771b255207bb30d428540d9ebd28ec32 Don't shy to make such trivial fixes in lines that you modify! ;) Thank you, Ivan

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.