On Friday 16 of December 2011, Matúš Kukan wrote:
Hi,
The build was not successful, there is problem in
testtools/source/bridgetest but
I created two patches. First is because of new c++ feature but I have
no idea if the second one is ok and what was the problem.
If "type ‘GraphicDescriptor’ is not a base type for
type 'unographic::Graphic’" was the only thing gcc said about it, then it's
probably a gcc bug, because clearly it is a base type for the class.
That said, the API appears to be broken. Graphic::Init() checks for previous
value mpGraphic, so that suggests it is possible to re-initialize the class
using this call. But then using this init() call first and later one of the
ones inherited from GraphicDescript will leave mpGraphic inconsistent.
Presumably the proper fix is to get rid of the init() calls and use directly
ctors for initialization.
--
Lubos Lunak
l.lunak@suse.cz
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.