Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limits<int>::min

Eike Rathke <erack -AT- redhat.com>
Tue, 13 Dec 2011 14:17:19 +0100

Hi Markus,

On Tuesday, 2011-12-13 00:15:08 +0100, Markus Mohrhard wrote:

the attached patch fixes a crash in our rtl::math lib. For
std::numeric_limits<int>::min() -nExp is the same as nExp and
therefore we would be in the first case and try to access a non
existing element.


Good catch. As Stephan said, please add a comment why the additional
check is in so it doesn't get "optimized out" if someone comes across
and reads the not so obvious code.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpgFSM3JR4hy.pgp
Description: PGP signature

Context

[Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limits<int>::min · Markus Mohrhard
- Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limits<int>::min · Kohei Yoshida
  - Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limits<int>::min · Lionel Elie Mamane
    - Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limits<int>::min · Kohei Yoshida
  - Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limits<int>::min · Markus Mohrhard
- Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limits<int>::min · Stephan Bergmann
- Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limits<int>::min · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.