Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limits<int>::min

Hi Markus,

On Tue, 2011-12-13 at 00:15 +0100, Markus Mohrhard wrote:

> the attached patch fixes a crash in our rtl::math lib. For
> std::numeric_limits<int>::min() -nExp is the same as nExp and
> therefore we would be in the first case and try to access a non
> existing element.

I would be interested to know how to reproduce this crash.  Do you have
a good way to reproduce this?

> Any objections against this patch? I think that this fix should be
> correct for all cases but it would be good if someone could have a
> look at it.

Well, I'm not necessarily objecting, but I'm a bit puzzled.  I would've
thought that, if nExp < 0 is true, -nExp > 0 is automatically true.
Anyway, if you have a code snippet that can make this code to segfault,
that would help me understand this better.

Thanks,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc