Re: [Libreoffice] [PATCH 01/11] Replace ScChangeTrackMsgStack with std::stack< ScChangeTrackMsgInfo* >

On 05/12/11 18:26, Eike Rathke wrote:
> Hi Marcel,
>
> On Thursday, 2011-12-01 11:08:40 +0100, Marcel Metz wrote:
>
> > this is my first patch series to the lo project. It replaces the use
> > of the tools Stack class and corresponding macros with the std::stack
> > as suggested in in bug #39445 [1] (an easy hack).
>
> As already mentioned on IRC on Friday, one thing that's missing is all
> replacements in the code of the binfilter repository, when reworking the
> entire code base that needs to be included in the build to catch things,
> here specifically the class Stack that will be gone now. The binfilter
> is in large pieces a snapshot of the code, but some low level modules
> are shared and not duplicated, as unfortunately here is the case with
> module tools. Note that to catch all places before building you best
> remove solver/$INPATH/inc/tools/stack.hxx and then
> rm binfilter/$INPATH/misc/*.dp*
> to remove the old dependency files the compiler would complain about
> because of the removed stack.hxx not found.
>
> Would be great if you could complete the work on binfilter.

clarifying remark:
please don't refactor binfilter, it is not worth the effort!

don't replace Stack with std::stack in binfilter, but instead just move
the header from tools somewhere into binfilter, adapt the #includes, and
be done with it.  one day we will throw out the binfilter altogether,
and there will be much rejoicing...