Re: [Libreoffice] [REVIEW] bidi/rtl languages (cosmetic change only)

On Mon, Dec 5, 2011 at 7:09 PM, Andras Timar <timar74@gmail.com> wrote:

> Hi Kaplan,
>
> 2011/12/4 Lior Kaplan <kaplanlior@gmail.com>:
> > Hi,
> >
> > Following Andrads's commit to the bidilanguages variable
> > (
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=93cf9e1f2b4a269dfe4fd90945dd2f7c50277db5
> ),
> > I've made a small cosmetic patch as these languages are RTL (which for
> them
> > we need bidi support).
> >
> > Comments?
>
> git grep -i bidi gives a lot more hits. Why would you like to change
> two variable names, while there are a lot more occurences in function
> names, etc. It would be more confusing than it is now.

As I said this is a cosmetic change, which is aiming for correctness of the
term itself.

Yes, bidi appears in a lot of places, most of them are the right use of the
term. This change is small and easy to do, otherwise it wouldn't worth the
time investment for something cosmetic.

Kaplan