Hi,
Following Andrads's commit to the bidilanguages variable (
http://cgit.freedesktop.org/libreoffice/core/commit/?id=93cf9e1f2b4a269dfe4fd90945dd2f7c50277db5),
I've made a small cosmetic patch as these languages are RTL (which for them
we need bidi support).
Comments?
Kaplan
From 1621b0d4defd2f4cf54d69afb0ad3e927a296fd7 Mon Sep 17 00:00:00 2001
From: Lior Kaplan <kaplanlior@gmail.com>
Date: Sun, 4 Dec 2011 23:36:02 +0200
Subject: [PATCH] It's RTL languages not bidi languages
---
solenv/bin/make_installer.pl | 6 +++---
solenv/bin/modules/installer/globals.pm | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/solenv/bin/make_installer.pl b/solenv/bin/make_installer.pl
index c9d9f02..3538d9a 100644
--- a/solenv/bin/make_installer.pl
+++ b/solenv/bin/make_installer.pl
@@ -2023,8 +2023,8 @@ for ( my $n = 0; $n <= $#installer::globals::languageproducts; $n++ )
{
my $onelanguage = ${$languagesarrayref}[$m];
- my $is_bidi = 0;
- if ( installer::existence::exists_in_array($onelanguage,
\@installer::globals::bidilanguages) ) { $is_bidi = 1; }
+ my $is_rtl = 0;
+ if ( installer::existence::exists_in_array($onelanguage,
\@installer::globals::rtllanguages) ) { $is_rtl = 1; }
my $languageidtdir = $idtdirbase . $installer::globals::separator . $onelanguage;
if ( -d $languageidtdir ) {
installer::systemactions::remove_complete_directory($languageidtdir, 1); }
@@ -2097,7 +2097,7 @@ for ( my $n = 0; $n <= $#installer::globals::languageproducts; $n++ )
# setting bidi attributes, if required
- if ( $is_bidi ) { installer::windows::idtglobal::setbidiattributes($languageidtdir,
$onelanguage); }
+ if ( $is_rtl ) { installer::windows::idtglobal::setbidiattributes($languageidtdir,
$onelanguage); }
# setting the encoding in every table (replacing WINDOWSENCODINGTEMPLATE)
installer::windows::idtglobal::set_multilanguageonly_condition($languageidtdir);
diff --git a/solenv/bin/modules/installer/globals.pm b/solenv/bin/modules/installer/globals.pm
index 48b61cc..079e681 100644
--- a/solenv/bin/modules/installer/globals.pm
+++ b/solenv/bin/modules/installer/globals.pm
@@ -99,7 +99,7 @@ BEGIN
);
@items_at_modules = ("Files", "Dirs", "Unixlinks");
@asianlanguages = ("ja", "ko", "zh-CN", "zh-TW");
- @bidilanguages = ("ar", "fa", "he", "ug");
+ @rtllanguages = ("ar", "fa", "he", "ug");
$ziplistname = "";
$pathfilename = "";
--
1.7.7.3
Context
- [Libreoffice] [REVIEW] bidi/rtl languages (cosmetic change only) · Lior Kaplan
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.